소스 검색

fix(gcp_pubsub): redact request when errors occur

Thales Macedo Garitezi 2 년 전
부모
커밋
dabefdb01b
2개의 변경된 파일7개의 추가작업 그리고 3개의 파일을 삭제
  1. 4 3
      apps/emqx_bridge_gcp_pubsub/src/emqx_bridge_gcp_pubsub_connector.erl
  2. 3 0
      apps/emqx_connector/src/emqx_connector_http.erl

+ 4 - 3
apps/emqx_bridge_gcp_pubsub/src/emqx_bridge_gcp_pubsub_connector.erl

@@ -355,7 +355,7 @@ do_send_requests_sync(State, {prepared_request, {Method, Path, Body}}, ResourceI
             ),
             ),
             ?SLOG(error, #{
             ?SLOG(error, #{
                 msg => "gcp_pubsub_error_response",
                 msg => "gcp_pubsub_error_response",
-                request => Request,
+                request => emqx_connector_http:redact_request(Request),
                 connector => ResourceId,
                 connector => ResourceId,
                 status_code => StatusCode
                 status_code => StatusCode
             }),
             }),
@@ -371,9 +371,10 @@ do_send_requests_sync(State, {prepared_request, {Method, Path, Body}}, ResourceI
             ),
             ),
             ?SLOG(error, #{
             ?SLOG(error, #{
                 msg => "gcp_pubsub_error_response",
                 msg => "gcp_pubsub_error_response",
-                request => Request,
+                request => emqx_connector_http:redact_request(Request),
                 connector => ResourceId,
                 connector => ResourceId,
-                status_code => StatusCode
+                status_code => StatusCode,
+                resp_body => RespBody
             }),
             }),
             {error, #{status_code => StatusCode, headers => RespHeaders, body => RespBody}}
             {error, #{status_code => StatusCode, headers => RespHeaders, body => RespBody}}
     end.
     end.

+ 3 - 0
apps/emqx_connector/src/emqx_connector_http.erl

@@ -42,6 +42,9 @@
     namespace/0
     namespace/0
 ]).
 ]).
 
 
+%% for other webhook-like connectors.
+-export([redact_request/1]).
+
 -export([validate_method/1, join_paths/2]).
 -export([validate_method/1, join_paths/2]).
 
 
 -type connect_timeout() :: emqx_schema:duration() | infinity.
 -type connect_timeout() :: emqx_schema:duration() | infinity.