fix: dialyzer and xref warnings

apps/emqx/src/emqx_persistent_session_ds.erl

@@ -82,7 +82,11 @@
 ]).
 
 %% session table operations
--export([create_tables/0, sync/1]).
+-export([sync/1]).
+-ifndef(STORE_STATE_IN_DS).
+-export([create_tables/0]).
+%% END ifndef(STORE_STATE_IN_DS).
+-endif.
 
 %% internal export used by session GC process
 -export([destroy_session/1]).
@@ -837,8 +841,11 @@ get_client_subscription(ClientId, TopicFilter) ->
 %% Session tables operations
 %%--------------------------------------------------------------------
 
+-ifndef(STORE_STATE_IN_DS).
 create_tables() ->
     emqx_persistent_session_ds_state:create_tables().
+%% END ifndef(STORE_STATE_IN_DS).
+-endif.
 
 %% @doc Force syncing of the transient state to persistent storage
 sync(ClientId) ->

apps/emqx/src/emqx_persistent_session_ds/emqx_persistent_session_ds_state.erl

@@ -116,7 +116,13 @@
 
 -opaque iter(K, V) :: gb_trees:iter(K, V).
 
+-ifdef(STORE_STATE_IN_DS).
+-opaque session_iterator() :: #{its := [emqx_ds:iterator()]} | '$end_of_table'.
+%% ELSE ifdef(STORE_STATE_IN_DS).
+-else.
 -opaque session_iterator() :: emqx_persistent_session_ds:id() | '$end_of_table'.
+%% END ifdef(STORE_STATE_IN_DS).
+-endif.
 
 -ifndef(STORE_STATE_IN_DS).
 %% Generic key-value wrapper that is used for exporting arbitrary
@@ -462,6 +468,7 @@ delete(Id) ->
 commit(Rec) ->
     commit(Rec, _Opts = #{}).
 
+-spec commit(t(), #{ensure_new => boolean()}) -> t().
 commit(Rec = #{dirty := false}, _Opts) ->
     Rec;
 commit(
@@ -543,12 +550,13 @@ store_batch(SessionId, Batch0, Opts) ->
             false ->
                 Batch0
         end,
-    emqx_ds:store_batch(?DB, Batch, #{atomic => true, sync => true}).
+    emqx_ds:store_batch(?DB, Batch, #{sync => true}).
 %% ELSE ifdef(STORE_STATE_IN_DS).
 -else.
 commit(Rec) ->
     commit(Rec, _Opts = #{}).
 
+-spec commit(t(), #{ensure_new => boolean()}) -> t().
 commit(Rec = #{dirty := false}, _Opts) ->
     Rec;
 commit(

apps/emqx/src/emqx_session.erl

@@ -198,7 +198,8 @@
 %% Create a Session
 %%--------------------------------------------------------------------
 
--spec create(clientinfo(), conninfo(), emqx_maybe:t(message())) -> {ok, t()} | {error, term()}.
+-spec create(clientinfo(), conninfo(), emqx_maybe:t(message())) ->
+    {ok, t()} | {error, recoverable | unrecoverable, term()}.
 create(ClientInfo, ConnInfo, MaybeWillMsg) ->
     Conf = get_session_conf(ClientInfo),
     % FIXME error conditions