Browse Source

Merge pull request #10172 from HJianBo/fix-typos-acl-file

fix(acl): fix wrong default ACL rules
JianBo He 2 years ago
parent
commit
b77aeb69cb
3 changed files with 18 additions and 1 deletions
  1. 1 1
      apps/emqx_authz/etc/acl.conf
  2. 9 0
      changes/ce/fix-10172.en.md
  3. 8 0
      changes/ce/fix-10172.zh.md

+ 1 - 1
apps/emqx_authz/etc/acl.conf

@@ -23,7 +23,7 @@
 %% -type(rule() :: {permission(), who(), access(), topics()} | {permission(), all}).
 %%--------------------------------------------------------------------
 
-{allow, {username, "^dashboard?"}, subscribe, ["$SYS/#"]}.
+{allow, {username, {re, "^dashboard$"}}, subscribe, ["$SYS/#"]}.
 
 {allow, {ipaddr, "127.0.0.1"}, all, ["$SYS/#", "#"]}.
 

+ 9 - 0
changes/ce/fix-10172.en.md

@@ -0,0 +1,9 @@
+Fix the incorrect default ACL rule, which was:
+```
+{allow, {username, "^dashboard?"}, subscribe, ["$SYS/#"]}.
+```
+
+However, it should use `{re, "^dashboard$"}` to perform a regular expression match:
+```
+{allow, {username, {re,"^dashboard$"}}, subscribe, ["$SYS/#"]}.
+```

+ 8 - 0
changes/ce/fix-10172.zh.md

@@ -0,0 +1,8 @@
+修复错误的默认 ACL 规则,之前是:
+```
+{allow, {username, "^dashboard?"}, subscribe, ["$SYS/#"]}.
+```
+但执行正则表达式的匹配应该使用 `{re, "^dashboard$"}`:
+```
+{allow, {username, {re, "^dashboard$"}}, subscribe, ["$SYS/#"]}.
+```