Browse Source

chore(build): Pin poolboy 1.5.2

mongodb-erlang uses a special fork:
https://github.com/comtihon/poolboy.git
(which has overflow_ttl feature added).
However, it references `{branch, "master}`
should be `{ref, "9c06a9a"}` (2021-04-07).
By accident, We have always been using the upstream fork due to
eredis_cluster's dependency getting resolved earlier.
Here we pin 1.5.2 to avoid surprises in the future.
Zaiming Shi 4 years ago
parent
commit
a914b191b6
2 changed files with 13 additions and 2 deletions
  1. 9 1
      apps/emqx_auth_mongo/rebar.config
  2. 4 1
      apps/emqx_auth_redis/rebar.config

+ 9 - 1
apps/emqx_auth_mongo/rebar.config

@@ -1,5 +1,13 @@
 {deps,
 {deps,
- [{mongodb, {git,"https://github.com/emqx/mongodb-erlang", {tag, "v3.0.7"}}}
+  %% NOTE: mind poolboy version when updating mongodb-erlang version
+ [{mongodb, {git,"https://github.com/emqx/mongodb-erlang", {tag, "v3.0.7"}}},
+  %% mongodb-erlang uses a special fork https://github.com/comtihon/poolboy.git
+  %% (which has overflow_ttl feature added).
+  %% However, it references `{branch, "master}` (commit 9c06a9a on 2021-04-07).
+  %% By accident, We have always been using the upstream fork due to
+  %% eredis_cluster's dependency getting resolved earlier.
+  %% Here we pin 1.5.2 to avoid surprises in the future.
+  {poolboy, {git, "https://github.com/emqx/poolboy.git", {tag, "1.5.2"}}}
  ]}.
  ]}.
 
 
 {edoc_opts, [{preprocess, true}]}.
 {edoc_opts, [{preprocess, true}]}.

+ 4 - 1
apps/emqx_auth_redis/rebar.config

@@ -1,5 +1,8 @@
 {deps,
 {deps,
- [{eredis_cluster, {git, "https://github.com/emqx/eredis_cluster", {tag, "0.6.4"}}}
+  %% NOTE: mind poolboy version when updating eredis_cluster version
+  %% poolboy version may clash with emqx_auth_mongo
+ [{eredis_cluster, {git, "https://github.com/emqx/eredis_cluster", {tag, "0.6.4"}}},
+  {poolboy, {git, "https://github.com/emqx/poolboy.git", {tag, "1.5.2"}}}
  ]}.
  ]}.
 
 
 {erl_opts, [warn_unused_vars,
 {erl_opts, [warn_unused_vars,