Переглянути джерело

refactor: clean up over complicated code

This commit cleans up overly complicated code and handles
the case when the worker pool is empty.

Thank you @thalesmg for suggesting this change.

Co-authored-by: Thales Macedo Garitezi <thalesmg@gmail.com>

Kjell Winblad 2 роки тому
батько
коміт
91514f3ace

+ 5 - 13
apps/emqx_bridge_dynamo/src/emqx_bridge_dynamo_connector.erl

@@ -198,20 +198,12 @@ on_get_status(_InstanceId, #{pool_name := Pool} = State) ->
     end.
 
 status_result(Results, State) ->
-    case lists:all(fun(Res) -> Res =:= true end, Results) of
-        true ->
+    case lists:filter(fun(Res) -> Res =/= true end, Results) of
+        [] when Results =:= [] ->
+            ?status_connecting;
+        [] ->
             ?status_connected;
-        false ->
-            {value, {false, Error}} =
-                lists:search(
-                    fun
-                        ({false, _Error}) ->
-                            true;
-                        (_) ->
-                            false
-                    end,
-                    Results
-                ),
+        [{false, Error} | _] ->
             {?status_connecting, State, Error}
     end.