Просмотр исходного кода

refactor(router): don't `emqx_broker_helper:monitor/1` in batches

As per out current understanding, this doesn't changes much in terms of
observability, since other nodes call `ekka:monitor(membership)` anyway,
so they will observe nodedowns without explicitly writing an entry into
the `?ROUTING_NODE` table.
Andrew Mayorov 2 лет назад
Родитель
Сommit
884f784c1c
1 измененных файлов с 0 добавлено и 16 удалено
  1. 0 16
      apps/emqx/src/emqx_router.erl

+ 0 - 16
apps/emqx/src/emqx_router.erl

@@ -246,8 +246,6 @@ mria_delete_route(v1, Topic, Dest, Ctx) ->
 
 -spec do_batch(batch()) -> #{batch_route() => _Error}.
 do_batch(Batch) ->
-    Nodes = batch_get_dest_nodes(Batch),
-    ok = lists:foreach(fun emqx_router_helper:monitor/1, ordsets:to_list(Nodes)),
     mria_batch(get_schema_vsn(), Batch).
 
 mria_batch(v2, Batch) ->
@@ -266,20 +264,6 @@ mria_batch_v1(Batch) ->
             Error
     end.
 
-batch_get_dest_nodes(Batch) ->
-    maps:fold(
-        fun({_Topic, Dest}, Op, Acc) ->
-            case batch_get_action(Op) of
-                add ->
-                    ordsets:add_element(get_dest_node(Dest), Acc);
-                delete ->
-                    Acc
-            end
-        end,
-        ordsets:new(),
-        Batch
-    ).
-
 batch_get_action(Op) ->
     element(1, Op).