Merge pull request #11486 from lafirest/fix/ldap_autn_wrong_pw

fix(ldap): Return correct reason code when password is wrong

apps/emqx_ldap/src/emqx_ldap_authn.erl

@@ -251,7 +251,7 @@ verify_password(Algorithm, LDAPPasswordType, LDAPPassword, Salt, Position, Passw
         true ->
             {ok, is_superuser(Entry, State)};
         _ ->
-            {error, invalid_password}
+            {error, bad_username_or_password}
     end.
 
 is_superuser(Entry, #{is_superuser_attribute := Attr} = _State) ->

apps/emqx_ldap/test/emqx_ldap_authn_SUITE.erl

@@ -237,7 +237,7 @@ user_seeds() ->
         %% Not exists
         New(<<"notexists">>, <<"notexists">>, {error, not_authorized}),
         %% Wrong Password
-        New(<<"mqttuser0001">>, <<"wrongpassword">>, {error, invalid_password}),
+        New(<<"mqttuser0001">>, <<"wrongpassword">>, {error, bad_username_or_password}),
         %% Disabled
         New(<<"mqttuser0006">>, <<"mqttuser0006">>, {error, user_disabled}),
         %% IsSuperuser