소스 검색

Merge pull request #8224 from zhongwencool/gateway-authn-mismatch

fix: don't merge gateway's authn
zhongwencool 3 년 전
부모
커밋
604f0d9511
2개의 변경된 파일7개의 추가작업 그리고 8개의 파일을 삭제
  1. 3 3
      apps/emqx/test/emqx_listeners_SUITE.erl
  2. 4 5
      apps/emqx_gateway/src/emqx_gateway_conf.erl

+ 3 - 3
apps/emqx/test/emqx_listeners_SUITE.erl

@@ -50,7 +50,7 @@ init_per_testcase(Case, Config) when
         Listeners -> emqx_config:put([listeners], maps:remove(quic, Listeners))
     end,
 
-    PrevListeners = emqx_config:get([listeners]),
+    PrevListeners = emqx_config:get([listeners], #{}),
     PureListeners = remove_default_limiter(PrevListeners),
     PureListeners2 = PureListeners#{
         tcp => #{
@@ -72,7 +72,7 @@ init_per_testcase(t_wss_conn, Config) ->
     catch emqx_config_handler:stop(),
     {ok, _} = emqx_config_handler:start_link(),
 
-    PrevListeners = emqx_config:get([listeners]),
+    PrevListeners = emqx_config:get([listeners], #{}),
     PureListeners = remove_default_limiter(PrevListeners),
     PureListeners2 = PureListeners#{
         wss => #{
@@ -97,7 +97,7 @@ init_per_testcase(t_wss_conn, Config) ->
 init_per_testcase(_, Config) ->
     catch emqx_config_handler:stop(),
     {ok, _} = emqx_config_handler:start_link(),
-    PrevListeners = emqx_config:get([listeners]),
+    PrevListeners = emqx_config:get([listeners], #{}),
     PureListeners = remove_default_limiter(PrevListeners),
     emqx_config:put([listeners], PureListeners),
     [

+ 4 - 5
apps/emqx_gateway/src/emqx_gateway_conf.erl

@@ -503,9 +503,8 @@ pre_config_update(_, {update_authn, GwName, Conf}, RawConf) ->
     of
         undefined ->
             badres_authn(not_found, GwName);
-        Authn ->
-            NAuthn = maps:merge(Authn, Conf),
-            {ok, emqx_map_lib:deep_put([GwName, ?AUTHN_BIN], RawConf, NAuthn)}
+        _Authn ->
+            {ok, emqx_map_lib:deep_put([GwName, ?AUTHN_BIN], RawConf, Conf)}
     end;
 pre_config_update(_, {update_authn, GwName, {LType, LName}, Conf}, RawConf) ->
     case
@@ -521,10 +520,10 @@ pre_config_update(_, {update_authn, GwName, {LType, LName}, Conf}, RawConf) ->
             case maps:get(?AUTHN_BIN, Listener, undefined) of
                 undefined ->
                     badres_listener_authn(not_found, GwName, LType, LName);
-                Auth ->
+                _Auth ->
                     NListener = maps:put(
                         ?AUTHN_BIN,
-                        maps:merge(Auth, Conf),
+                        Conf,
                         Listener
                     ),
                     {ok,