Преглед на файлове

Merge pull request #10324 from kjellwinblad/kjell/fix/EMQX-9374

fix: check Clickhouse connection after creation
Kjell Winblad преди 2 години
родител
ревизия
601564fa0a
променени са 3 файла, в които са добавени 11 реда и са изтрити 2 реда
  1. 1 0
      changes/ee/fix-10324.en.md
  2. 1 0
      changes/ee/fix-10324.zh.md
  3. 9 2
      lib-ee/emqx_ee_connector/src/emqx_ee_connector_clickhouse.erl

+ 1 - 0
changes/ee/fix-10324.en.md

@@ -0,0 +1 @@
+Previously, when attempting to reconnect to a misconfigured Clickhouse bridge through the dashboard, users would not receive an error message. This issue is now resolved, and error messages will now be displayed

+ 1 - 0
changes/ee/fix-10324.zh.md

@@ -0,0 +1 @@
+

+ 9 - 2
lib-ee/emqx_ee_connector/src/emqx_ee_connector_clickhouse.erl

@@ -270,8 +270,15 @@ connect(Options) ->
         {pool_size, PoolSize}
     ],
     case clickhouse:start_link(FixedOptions) of
-        {ok, _Conn} = Ok ->
-            Ok;
+        {ok, Connection} ->
+            %% Check if we can connect and send a query
+            case clickhouse:detailed_status(Connection) of
+                ok ->
+                    {ok, Connection};
+                Error ->
+                    ok = clickhouse:stop(Connection),
+                    Error
+            end;
         {error, Reason} ->
             {error, Reason}
     end.