Просмотр исходного кода

fix(ds): Apply review remarks

Co-authored-by: Thales Macedo Garitezi <thalesmg@gmail.com>
ieQu1 2 лет назад
Родитель
Сommit
5aa9d026df
1 измененных файлов с 3 добавлено и 1 удалено
  1. 3 1
      apps/emqx/src/emqx_persistent_message_ds_replayer.erl

+ 3 - 1
apps/emqx/src/emqx_persistent_message_ds_replayer.erl

@@ -242,8 +242,10 @@ packet_id_to_seqno_test() ->
     ?assertEqual(1, packet_id_to_seqno(1, 1)),
     ?assertEqual(1, packet_id_to_seqno(10, 1)),
     ?assertEqual(1, packet_id_to_seqno(1 bsl 16 - 1, 1)),
+    ?assertEqual(1, packet_id_to_seqno(1 bsl 16, 1)),
     %% Packet ID = 1; second and 3rd epochs:
     ?assertEqual(1 bsl 16 + 1, packet_id_to_seqno(1 bsl 16 + 1, 1)),
+    ?assertEqual(1 bsl 16 + 1, packet_id_to_seqno(2 bsl 16, 1)),
     ?assertEqual(2 bsl 16 + 1, packet_id_to_seqno(2 bsl 16 + 1, 1)),
     %% Packet ID = 16#ffff:
     PID = 1 bsl 16 - 1,
@@ -279,7 +281,7 @@ next_seqno_gen() ->
     ).
 
 seqno_gen(NextSeqNo) ->
-    WindowSize = 1 bsl 16 - 2,
+    WindowSize = 1 bsl 16 - 1,
     Min = max(0, NextSeqNo - WindowSize),
     Max = max(0, NextSeqNo - 1),
     range(Min, Max).