Просмотр исходного кода

chore: add changlog for authn_http validation

Zhongwen Deng 2 лет назад
Родитель
Сommit
2aef9ca215
2 измененных файлов с 2 добавлено и 17 удалено
  1. 0 17
      apps/emqx_authn/test/emqx_authn_https_SUITE.erl
  2. 2 0
      changes/ce/fix-10449.en.md

+ 0 - 17
apps/emqx_authn/test/emqx_authn_https_SUITE.erl

@@ -114,22 +114,6 @@ t_create_invalid_version(_Config) ->
         emqx_access_control:authenticate(?CREDENTIALS)
     ).
 
-t_create_disable_ssl_opts_when_https(_Config) ->
-    {ok, _} = create_https_auth_with_ssl_opts(
-        #{
-            <<"server_name_indication">> => <<"authn-server">>,
-            <<"verify">> => <<"verify_peer">>,
-            <<"versions">> => [<<"tlsv1.2">>],
-            <<"ciphers">> => [<<"ECDHE-RSA-AES256-GCM-SHA384">>],
-            <<"enable">> => <<"false">>
-        }
-    ),
-
-    ?assertEqual(
-        {error, not_authorized},
-        emqx_access_control:authenticate(?CREDENTIALS)
-    ).
-
 t_create_invalid_ciphers(_Config) ->
     {ok, _} = create_https_auth_with_ssl_opts(
         #{
@@ -151,7 +135,6 @@ t_create_invalid_ciphers(_Config) ->
 
 create_https_auth_with_ssl_opts(SpecificSSLOpts) ->
     AuthConfig = raw_https_auth_config(SpecificSSLOpts),
-    ct:pal("111:~p~n", [AuthConfig]),
     emqx:update_config(?PATH, {create_authenticator, ?GLOBAL, AuthConfig}).
 
 raw_https_auth_config(SpecificSSLOpts) ->

+ 2 - 0
changes/ce/fix-10449.en.md

@@ -0,0 +1,2 @@
+Validate the ssl_options and header configurations when creating authentication http (`authn_http`).
+Prior to this, incorrect ssl_options configuration could result in successful creation but the entire authn being unusable.