Преглед изворни кода

fix(audit): disable audit log by default

Zaiming (Stone) Shi пре 2 година
родитељ
комит
26cadb2248

+ 1 - 1
apps/emqx_enterprise/src/emqx_enterprise_schema.erl

@@ -160,7 +160,7 @@ audit_log_conf() ->
                     %% `emqx_conf:gen_config_md' seems to expect.
                     desc => ?DESC(emqx_conf_schema, "log_audit_handler"),
                     importance => ?IMPORTANCE_HIGH,
-                    default => #{<<"enable">> => true, <<"level">> => <<"info">>}
+                    default => #{<<"enable">> => false, <<"level">> => <<"info">>}
                 }
             )}
     ].

+ 1 - 1
apps/emqx_enterprise/test/emqx_enterprise_schema_SUITE.erl

@@ -92,7 +92,7 @@ t_audit_log_conf(_Config) ->
             #{<<"default">> => FileExpect},
         <<"audit">> =>
             #{
-                <<"enable">> => true,
+                <<"enable">> => false,
                 <<"level">> => <<"info">>,
                 <<"path">> => <<"log/audit.log">>,
                 <<"rotation_count">> => 10,

+ 2 - 2
apps/emqx_enterprise/test/emqx_enterprise_schema_tests.erl

@@ -19,14 +19,14 @@ doc_gen_test() ->
 
 audit_log_test() ->
     ensure_acl_conf(),
-    Conf0 = <<"node {cookie = aaa, data_dir = \"/tmp\"}">>,
+    Conf0 = <<"node {cookie = aaa, data_dir = \"/tmp\"}, log.audit.enable=true">>,
     {ok, ConfMap0} = hocon:binary(Conf0, #{format => richmap}),
     ConfList = hocon_tconf:generate(emqx_enterprise_schema, ConfMap0),
     Kernel = proplists:get_value(kernel, ConfList),
     Loggers = proplists:get_value(logger, Kernel),
     FileHandlers = lists:filter(fun(L) -> element(3, L) =:= logger_disk_log_h end, Loggers),
     AuditHandler = lists:keyfind(emqx_audit, 2, FileHandlers),
-    %% default is enable and log level is info.
+    %% default log level is info.
     ?assertMatch(
         {handler, emqx_audit, logger_disk_log_h, #{
             config := #{