瀏覽代碼

fix(iotdb): make dialyzer happy

firest 1 年之前
父節點
當前提交
0bebd66f05
共有 2 個文件被更改,包括 6 次插入7 次删除
  1. 5 6
      apps/emqx_bridge_iotdb/src/emqx_bridge_iotdb_connector.erl
  2. 1 1
      changes/ee/feat-12602.en.md

+ 5 - 6
apps/emqx_bridge_iotdb/src/emqx_bridge_iotdb_connector.erl

@@ -9,6 +9,7 @@
 -include_lib("emqx/include/logger.hrl").
 -include_lib("hocon/include/hoconsc.hrl").
 -include_lib("snabbkaffe/include/snabbkaffe.hrl").
+-include_lib("emqx_resource/include/emqx_resource.hrl").
 
 %% `emqx_resource' API
 -export([
@@ -70,8 +71,6 @@
 
 -import(hoconsc, [mk/2, enum/1, ref/2]).
 
--dialyzer({no_match, [on_get_channel_status/3]}).
-
 %%-------------------------------------------------------------------------------------
 %% connector examples
 %%-------------------------------------------------------------------------------------
@@ -240,7 +239,7 @@ on_stop(InstanceId, State) ->
     Res.
 
 -spec on_get_status(manager_id(), state()) ->
-    {connected, state()} | {disconnected, state(), term()}.
+    connected | connecting | {disconnected, state(), term()}.
 on_get_status(InstanceId, #{base_path := BasePath} = State) ->
     Func = fun(Worker, Timeout) ->
         Request = {?IOTDB_PING_PATH, [], undefined},
@@ -375,10 +374,10 @@ on_get_channels(InstanceId) ->
 
 on_get_channel_status(InstanceId, _ChannelId, State) ->
     case on_get_status(InstanceId, State) of
-        connected ->
-            connected;
+        ?status_connected ->
+            ?status_connected;
         _ ->
-            disconnected
+            ?status_disconnected
     end.
 
 %%--------------------------------------------------------------------

+ 1 - 1
changes/ee/feat-12602.en.md

@@ -1 +1 @@
-Enhanced health checking for IOTDB connector, using its `ping` API replacing the old method which only validating via a socket connection.
+Enhanced health checking for IoTDB connector, using its `ping` API instead of just checking for an existing socket connection.